Valknut Analysis Report

Comprehensive code quality analysis and refactoring guidance

2025-12-01T19:10:22.428Z

Analysis Summary

Files Analyzed 72
Code Entities 2738
Need Refactoring 568
Doc Issues 57
Assessment: Service-heavy monolith

Core analysis pipeline is cohesive but tightly coupled across CLI, pipeline, and detectors; duplicate parsing and config layering paths could be consolidated to reduce drift and unlock better CLI/daemon reuse.

Roadmap
1 required 2 optional
Unify config layering and CLI overrides config
src/bin/cli/config_layer.rs src/bin/cli/commands.rs src/core/config.rs

Collapse duplicated config merging logic so LSH/coverage toggles are consistently honored across profiles and custom runs.

Add a single merge helper and re-use in CLI + daemon paths.

Impact High
Effort Medium
Risk Medium
Extract coverage file discovery into shared service optional coverage
src/core/file_utils.rs src/detectors/coverage/mod.rs

Expose a reusable discovery function so CLI and tests share the same rules; removes need for multiple search path lists.

Impact Medium
Effort Low
Risk Low
Normalize clone denoise thresholds for dev presets optional clones
src/core/pipeline/pipeline_executor.rs src/bin/cli/commands.rs

Wire semantic clone toggles and low-threshold presets into the LSH extractor so dev builds always emit pairs for the UI demo.

Impact Medium
Effort Low
Risk Low
Clones 2
Average Similarity 0.75
Maximum Similarity 0.82
Candidates —
Raw Analysis Data 
Loading…